Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: Fix NVIDIA build instructions #3472

Closed
torrance opened this issue May 6, 2024 · 2 comments
Closed

[Documentation]: Fix NVIDIA build instructions #3472

torrance opened this issue May 6, 2024 · 2 comments

Comments

@torrance
Copy link

torrance commented May 6, 2024

Description of errors

Since at least v6.0, the build process for NVIDIA has required cloning https://github.com/ROCm/hipother.git, however this is not mentioned anywhere in the documentation here: https://rocm.docs.amd.com/projects/HIP/en/latest/developer_guide/build.html

Please add this repository as a requisite for building for NVIDIA.

Attach any links, screenshots, or additional evidence you think will be helpful.

No response

@ppanchad-amd
Copy link

@torrance Internal ticket has been created to fix this. Thanks!

@harkgill-amd
Copy link

Hi @torrance, the ROCm 6.2.0 documentation address the hipother repo in it's build instructions at Build HIP from source. The below excerpt is taken directly from the documentation under the NVIDIA tab.

1. Get the HIP source code.

git clone -b "$ROCM_BRANCH" https://github.com/ROCm/clr.git
git clone -b "$ROCM_BRANCH" https://github.com/ROCm/hip.git
git clone -b "$ROCM_BRANCH" https://github.com/ROCm/hipother.git

2. Set the environment variables.

export CLR_DIR="$(readlink -f clr)"
export HIP_DIR="$(readlink -f hip)"
export HIP_OTHER="$(readlink -f hipother)"

3. Build HIP.

cd "$CLR_DIR"
mkdir -p build; cd build
cmake -DHIP_COMMON_DIR=$HIP_DIR -DHIP_PLATFORM=nvidia -DCMAKE_INSTALL_PREFIX=$PWD/install -DHIP_CATCH_TEST=0 -DCLR_BUILD_HIP=ON -DCLR_BUILD_OCL=OFF -DHIPNV_DIR=$HIP_OTHER/hipnv ..
make -j$(nproc)
sudo make install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants