Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pyLDAPI.Renderer.render() #9

Open
edmondchuc opened this issue Nov 16, 2018 · 0 comments
Open

Refactor pyLDAPI.Renderer.render() #9

edmondchuc opened this issue Nov 16, 2018 · 0 comments
Assignees

Comments

@edmondchuc
Copy link
Collaborator

"I will be looking into refactoring parts of the pyLDAPI – more specifically the current requirement of using pyldapi.Renderer._render_alternates_view() for custom Renderer classes. If it’s required to be called manually, it should ideally drop the prefix underscore. Otherwise see if it’s possible to refactor it to the behaviour of the RegisterRenderer class where it’s handled automatically by the tool. "

Here is a live example of a possible solution where the end result will allow the business code to just call SomeClassRenderer.render(): https://repl.it/@edmondchuc/pyLDAPI-Renderer-class-refactor-example

This will keep it in line with the usage of the pyldapi.RegisterRenderer.render().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants