-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow appending multiple Set-Cookie Headers #1851
Comments
I think good cookie support is super important, wanna take into preparing a PR most likely inspired by sveltekit and astro? This would be such a massive improvement!! |
Definitely! I was going to take it on yesterday, but it looks like Qwik City e2e tests are broken. I'm guessing because of the refactor Adam did on the middlewares/servers. |
Opened a PR at #1864 On paper, I think this would fix the issue, but without being able to run tests, I don't feel comfortable merging yet. |
PR is ready for review! |
Is your feature request related to a problem?
The current headers implementation uses an append function that concatenates header values together with a ", ". This works for all headers except Set-Cookie.
Describe the solution you'd like
There are a few options I can think of:
getCookie
,setCookie
,appendCookie
.Describe alternatives you've considered
Additional context
whatwg/fetch#973 - Discussion around formalizing a solution for Set-Headers
https://github.com/withastro/astro/pull/3092/files - Astro PR using the adding multiple Set-Cookies for Netlify
https://github.com/sveltejs/kit/pull/3502/files - Svelte PR adding multiple Set-Cookies
The text was updated successfully, but these errors were encountered: