-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ responsive sidebar #1279
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/components/ChatsList/components/ChatHistory.tsx The code seems to be well written and follows the SOLID principles. However, there is a potential performance issue. The const todayChats = useMemo(() => allChats.filter((chat) =>
isToday(new Date(chat.creation_time))
), [allChats]); Do the same for Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/components/Sidebar/Sidebar.tsx The code seems to be well written and follows the SOLID principles. However, there is a potential performance issue. The Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/brains-management/[brainId]/components/BrainsList/BrainsList.tsx The code seems to be well written and follows the SOLID principles. However, there is a potential performance issue. The const renderedBrains = useMemo(() => brains.map((brain) => (
<BrainListItem brain={brain} key={brain.id} />
)), [brains]); Then use 📝🚀🔧 Powered by Code Review GPT |
00ff57b
to
7a682c5
Compare
{path === null || | ||
path.startsWith("/chat") || | ||
path.startsWith("/brains-management") ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For improved readability, you can:
- Declare a constant
myConst
equal to your checks. - Implement an early return, so if
myConst
is not true, return ...
Nice PR @matthieujacq! |
Description
Screenshots (if appropriate):