Remove ENABLE_OFFLOAD_CLANG_DEBUG_O3 option in CMake and raise Clang minimal version to 16 when using offload #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…minimal version to 16 for offload.
|
@prckent I have no issue with a debug build using rocm 6.2 |
|
Test this please |
|
(Would like to run this on our MI210s and confirm all is OK locally later today. Currently doing some dependent software rebuilds. Will merge if these take too long or have issues. ) |
prckent
approved these changes
Aug 15, 2024
|
Test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I got nvlink failure when using llvm 15 but 16 was OK. So raise the minimal version to 16 when using offload.
Closes #5127. Debug build works fine with clang 16 without -O3.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist