Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable event duration in pyplr.utils #10

Open
sbonavia opened this issue Feb 6, 2024 · 1 comment
Open

Variable event duration in pyplr.utils #10

sbonavia opened this issue Feb 6, 2024 · 1 comment

Comments

@sbonavia
Copy link

sbonavia commented Feb 6, 2024

Hello,
I am carrying our research on light direction and pupil size and find the pyplr software here very useful, thank you. It would be useful if within the 'utils' module there is an option for the 'duration' to be linked to a duration column in the 'events' dataframe so that the function applies to variable event durations. It seems that this option was planned. I am also looking into introducing this into the function.
Best
Simone

@jtmbeta
Copy link
Member

jtmbeta commented Feb 6, 2024

Hi Simone,
I'm pleased to hear that the software has proved useful. Yes, support for variable durations was planned and is a good idea, but I didn't get round to implementing it in the code as it was not required for my own analyses at the time of development. I'll get round to it eventually, but please feel free to submit a pull request if you come up with a good solution in the meantime.
Best
Joel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants