Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor bug] Highlighted area stays after package deactivation/reactivation #208

Open
scsmash3r opened this issue Nov 22, 2019 · 0 comments

Comments

@scsmash3r
Copy link

scsmash3r commented Nov 22, 2019

Atom: 1.41.0 x64
OS: Win 8.1
Highlight Selected: 0.16.0

To reproduce:

  1. Highlight something in any file.
  2. Press CTRL+, (open Settings tab) without removing the highlights.
  3. Disable this package.
  4. Go back to the file tab.

Without custom styles added, it will seem that highlights are gone. But if you re-enable package, old highlight zones reappear.

With a custom style, where background is changed, it will be even more noticeable:

atom-text-editor {
  .highlights .highlight-selected.background .region {
    background-color: rgba(60, 80, 255, 0.7);
  }
}

Ofc, reopening the file 'cures' this behavior and removes old highlights.
I guess there should be some event like onPackageDeactivation or something (not familiar with Atom API) to clear the highlight zones before package disabling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant