Merge branch 'pj/fix/VPNAPPL-2102-retain-cycle-video-tour' into 'deve…

…lop' Merge-Request: apple/vpn/protonvpn!1598 Approved-by: Adam Viaud <[email protected]>
ProtonVPN · Feb 12, 2024 · f0f94a0 · f0f94a0
2 parents 3c046a8 + d8d5ad5
commit f0f94a0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/.../ProtonVPN/Scenes/SystemExtension/ViewContollers/SystemExtensionGuideViewController.swift b/.../ProtonVPN/Scenes/SystemExtension/ViewContollers/SystemExtensionGuideViewController.swift
@@ -48,11 +48,13 @@ class SystemExtensionGuideViewController: NSViewController {
  super.viewDidLoad()
  NotificationCenter.default
  .publisher(for: SystemExtensionManager.allExtensionsInstalled)
- .sink(receiveValue: allExtensionsInstalled)
+ .sink(receiveValue: { [weak self] _ in
+ self?.allExtensionsInstalled()
+ })
  .store(in: &cancellables)
  }
 
- func allExtensionsInstalled(_ notification: Notification) {
+ func allExtensionsInstalled() {
  finishedTour = true
  self.view.window?.close()
  }

diff --git a/apps/macos/ProtonVPN/Scenes/SystemExtension/ViewModels/VideoTourModel.swift b/apps/macos/ProtonVPN/Scenes/SystemExtension/ViewModels/VideoTourModel.swift
@@ -66,11 +66,13 @@ class VideoTourModel {
  player.rate = 0.5
  NotificationCenter.default
  .publisher(for: .AVPlayerItemDidPlayToEndTime, object: player.currentItem)
- .sink(receiveValue: itemDidPlayToEndTime)
+ .sink(receiveValue: { [weak self] _ in
+ self?.itemDidPlayToEndTime()
+ })
  .store(in: &cancellables)
  }
 
- private func itemDidPlayToEndTime(_ notification: Notification) {
+ private func itemDidPlayToEndTime() {
  player.seek(to: .zero)
  player.play()
  }