Merge branch 'cj/test/fix-flaky-cert-refresh-test' into 'develop'

Merge-Request: apple/vpn/protonvpn!1589 Approved-by: Jaroslav Ozevič <[email protected]>
ProtonVPN · Feb 5, 2024 · 6fdca16 · 6fdca16
2 parents 2bf285c + fb72441
commit 6fdca16
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/libraries/NEHelper/Tests/NEHelperTests/ExtensionAPITests/CertificateRefreshTests.swift b/libraries/NEHelper/Tests/NEHelperTests/ExtensionAPITests/CertificateRefreshTests.swift
@@ -751,9 +751,8 @@ class CertificateRefreshTests: ExtensionAPIServiceTestCase {
  XCTFail("Shouldn't have tried to refresh; operation should have been cancelled")
  }
  expectations.managerStop.fulfill()
+ self.timerFactory.runAllScheduledWork()
  }
-
- timerFactory.runAllScheduledWork()
  wait(for: [expectations.certRefreshCancelled, expectations.managerStop], timeout: expectationTimeout, enforceOrder: true)
  }
 

diff --git a/libraries/NEHelper/Tests/NEHelperTests/ExtensionAPITests/ExtensionAPIServiceTestCase.swift b/libraries/NEHelper/Tests/NEHelperTests/ExtensionAPITests/ExtensionAPIServiceTestCase.swift
@@ -118,7 +118,7 @@ class ExtensionAPIServiceTestCase: XCTestCase, ExtensionAPIServiceDelegate {
  serverStatusCallback = failCallback
 
  keychain = MockAuthKeychain()
- try! await keychain.store(AuthCredentials(username: "johnny",
+ try! keychain.store(AuthCredentials(username: "johnny",
  accessToken: "12345",
  refreshToken: "54321",
  sessionId: "15213",