[feat] [#31] Map 화면 바텀시트 구현 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compose-foundation 내에 class 를 찾지 못하는 문제 해결
string resource 추가
ic_delete_gray drawable resource 추가
일반 SearchTextField 와 SearchMode 가 존재하는 (뒤로가기, 하단 뷰 안보이게 하는 설정) FestivalSearchTextField 로 분리
UnifestOutlinedButton 보완
system-ui-controller -> compose-system-ui-controller 로 네이밍 변경
compose-state-keyboard 라이브러리 적용 및, Scaffold padding 관련 보일러 플레이트 제거
FlexibleSearchBottomSheet 사용, but issue 존재
…s 연동 code style check success
easyhooon
added
enhancement
Closed
|
열심히 읽었는데 바텀시트부터 시작해서 인트로 구조까지 바꾸는 대작업이셨군요.. 수고 너무 많으셨습니다 |
wjdtkdgns777
approved these changes
Apr 10, 2024
좋은 지적입니다. 저도 고쳐볼려고했는데 딱 가운데로 안가더군여. 이전에 만들었던 앱에서도 아직 못고쳤던 문제인데, 이번 기회 한번 고쳐봐야겠습니다 |
# Conflicts: # core/designsystem/src/main/kotlin/com/unifest/android/core/designsystem/component/TopAppBar.kt # feature/main/src/main/kotlin/com/unifest/android/feature/main/MainScreen.kt # feature/map/src/main/kotlin/com/unifest/android/feature/map/MapScreen.kt # feature/map/src/main/kotlin/com/unifest/android/feature/map/navigation/MapNavigation.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> 다만 해당 Scaffold 내에 포함되는 화면들(Home, Map, Waiting, Menu)만 적용되는 지라, Intro, 관심축제 내에 포함된 TextField 는 적용되지 않음, 근원적인 코드 레벨에서의 해결 필요 (이슈에 등록해두겠습니다)
TODO
-> 하나의 feature 가 너무 헤비해지는 관계로 얘네는 다음 feature 에서 진행하도록 하겠습니다.