Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checked google sign out #104

Closed
wants to merge 1 commit into from
Closed

Checked google sign out #104

wants to merge 1 commit into from

Conversation

sarthakvaishnav09
Copy link

@sarthakvaishnav09 sarthakvaishnav09 commented Oct 3, 2021 •
edited
Loading

Description

Checked the Google sign out method

Fixes #98

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the code of conduct of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@Mohitmadhav
Copy link
Member

@sarthakvaishnav09 did you test whether Google logout is working or not?
My device is down right now.

@sarthakvaishnav09
Copy link
Author

Couldn't test it because the profile tab just shows circular progress bar all the time due to some other issue, but I checked whether the google sign out method and push replacement code is correct.

If this issue is resolved, I would be able to test it on my device.

Screenshot_20211003-140825

@Mohitmadhav
Copy link
Member

Couldn't test it because the profile tab just shows circular progress bar all the time due to some other issue, but I checked whether the google sign out method and push replacement code is correct.

If this issue is resolved, I would be able to test it on my device.

Screenshot_20211003-140825

Did you sign in through google?

Also try out:

  • git pull upstream main
  • flutter clean
  • flutter packages get

then try to sign in and sign out again through google.

@Mohitmadhav
Copy link
Member

@sarthakvaishnav09 is the profile page loading now?

Mohitmadhav
Mohitmadhav requested changes Oct 3, 2021
View reviewed changes
Copy link
Member

@Mohitmadhav Mohitmadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Also in the file private_profile.dart change the push replacement code because the user is navigating back to the Initial screen.

Hope you understood!!

So remove the gesture detector, and put the sign-out command inside the onPressed function.
Then check whether it's working or not

@sarthakvaishnav09
Copy link
Author

Yeah working on it.

@Mohitmadhav
Copy link
Member

Yeah working on it.

@sarthakvaishnav09 notify once you are done.

@Mohitmadhav
Copy link
Member

This has been resolved through another issue.
And please follow up @sarthakvaishnav09.
I'm closing this PR. You can take up other issues if you want, and keep updating regularly.

@Mohitmadhav Mohitmadhav closed this Oct 8, 2021
@sarthakvaishnav09
Copy link
Author

@Mohitmadhav Okay np !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohitmadhav Mohitmadhav Mohitmadhav requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Google Sign-out
2 participants
@sarthakvaishnav09 @Mohitmadhav