Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null safety Migration #143

Merged
merged 12 commits into from
Oct 19, 2021
Merged

Null safety Migration #143

merged 12 commits into from
Oct 19, 2021

Conversation

keyurgit45
Copy link
Contributor

Description

Summary of the changes and which issue is fixed.
Migrated to null safety. Added all packages to their null safety versions in pubspec.yaml. Replaced Quotes package with Quotes API.
Fixes #95

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • My code follows the code of conduct of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@Mohitmadhav
Copy link
Member

Mohitmadhav commented Oct 14, 2021 •
edited
Loading

@keyurgit45 I'm not able to signin .....Nothing happens when I click on google sign in button
And why did you change the font?

I'm able to Login with Email but there's no quote on the Dashboard

@keyurgit45
Copy link
Contributor Author

@keyurgit45 I'm not able to signin .....Nothing happens when I click on google sign in button
And why did you change the font?

I'm able to Login with Email but there's no quote on the Dashboard

Let me see.. Actually we were using muli font which was showing error after upgrading package so I changed in to mali.. You can tell me another font I will change to it.

@Mohitmadhav
Copy link
Member

Okay @keyurgit45 change it to Lato font

@Mohitmadhav Mohitmadhav merged commit 113f2fb into Project-Easter:main Oct 19, 2021
@Mohitmadhav Mohitmadhav added the hacktoberfest-accepted Approval of PR in Hacktober fest label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null Safety Migration
2 participants
@keyurgit45 @Mohitmadhav