Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamped Book and User Collections #129

Merged
merged 5 commits into from
Oct 7, 2021
Merged

Revamped Book and User Collections #129

merged 5 commits into from
Oct 7, 2021

Conversation

keyurgit45
Copy link
Contributor

@keyurgit45 keyurgit45 commented Oct 7, 2021 •
edited
Loading

Description

Revamped books and user collection. added given fields. earlier add book button was not working. Fixed add book button functionality. Now when a user adds a book, it gets added in both users and books collections under owned books. (as per discussion)
Summary of the changes and which issue is fixed.

Fixes #92

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code of conduct of this project
  • [x My code follows the style guidelines of this project
  • My changes generate no new warnings
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Mohitmadhav
Mohitmadhav requested changes Oct 7, 2021
View reviewed changes
Copy link
Member

@Mohitmadhav Mohitmadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I added the book The Alchemist but the above book got added.
We need to look into that.
Rest everything is fine.

@keyurgit45
Copy link
Contributor Author

@Mohitmadhav It is working on my device. did you add this ISBN no: 9780062416216?

@Mohitmadhav
Copy link
Member

@Mohitmadhav It is working on my device. did you add this ISBN no: 9780062416216?

Mine is: 9788172234980

@Mohitmadhav
Copy link
Member

Mohitmadhav commented Oct 7, 2021 •
edited
Loading

image

Even Google is saying that.
Let's see how to resolve this

@Mohitmadhav
Copy link
Member

@Mohitmadhav I referred to the google API docs. maybe I found a solution. we need to modify the URL: https://www.googleapis.com/books/v1/volumes?q=the%20alchemist+isbn:9788172234980 ref: https://developers.google.com/books/docs/v1/using#ids

See the discussions.

@Mohitmadhav
Copy link
Member

Notify once you are done @keyurgit45

@keyurgit45
Copy link
Contributor Author

keyurgit45 commented Oct 7, 2021 •
edited
Loading

Notify once you are done @keyurgit45

I'm done. I made PR 2 hrs ago. I thought you will get notified 😅

@Mohitmadhav
Copy link
Member

image
image

Why is it different for the 2 branches? In main earlier I had 2 books saved but not in your branch. Why is that any idea?
@keyurgit45

@Mohitmadhav
Copy link
Member

No worries @keyurgit45 , that was some cache error, will look into it later.

@Mohitmadhav Mohitmadhav added the hacktoberfest-accepted Approval of PR in Hacktober fest label Oct 7, 2021
@Mohitmadhav Mohitmadhav merged commit 2f97ab1 into Project-Easter:main Oct 7, 2021
@keyurgit45
Copy link
Contributor Author

keyurgit45 commented Oct 7, 2021 •
edited
Loading

Actually, I didn't change anything other than add_book button's code. What are we basically doing is The same book is being added in users and books collection under owned books so when we are fetching data in the Library page we are taking from users collection not from books. That's the basic idea. @Mohitmadhav

@Mohitmadhav
Copy link
Member

Yeah got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohitmadhav Mohitmadhav Mohitmadhav approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revamp Book and User Collections
2 participants
@keyurgit45 @Mohitmadhav