-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix UI of the personalize button #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AryanKhubchandani for resolving the null error:
- flutter clean
- flutter packages get
- git pull upstream main
The dialog is loading in my local system. You do this and then notify me.
@Mohitmadhav I tried this before too, the error persists. |
I updated the main branch yesterday, didn't you get the changes in some files? |
Yes I did get some changes, but the error still exists. |
@AryanKhubchandani I switched to your branch and it opened this time. Once clean your app cache and uninstall it. |
Sure, I will update you regarding the same. Thanks! |
The issue still exists for some reason :/ |
Send the debug console screenshot here |
Now check @AryanKhubchandani , I have resolved the conflicts |
Yeah I fixed the button, will push the changes once I am done with the user preferences too |
@AryanKhubchandani now are you able to click Personalize button? |
No, haha. Something is still wrong. Nonetheless, I fixed the color of both the button and the choice chips. Please check for review. |
@AryanKhubchandani now you can delete your branch and create another one and check after git pull upstream main because it's working all right in the main branch. |
Alright, I will give it a try! |
Description
This is in reference to issue #86. The UI of the personalize button has been fixed for light theme. An obsolete version of MaterialButton was being used for personalize button, so I changed it to TextButton inorder to add a button theme in the light theme data. The personalize button is throwing an error "The getter 'preferences' was called on null.", so I could not work on changing the color of use preferences buttons. Please suggest how to proceed further.
Type of change
Checklist: