Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix UI of the personalize button #123

Merged
merged 6 commits into from
Oct 7, 2021
Merged

fix: fix UI of the personalize button #123

merged 6 commits into from
Oct 7, 2021

Conversation

AryanKhubchandani
Copy link
Contributor

Description

This is in reference to issue #86. The UI of the personalize button has been fixed for light theme. An obsolete version of MaterialButton was being used for personalize button, so I changed it to TextButton inorder to add a button theme in the light theme data. The personalize button is throwing an error "The getter 'preferences' was called on null.", so I could not work on changing the color of use preferences buttons. Please suggest how to proceed further.

0
0

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code of conduct of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Mohitmadhav
Mohitmadhav requested changes Oct 5, 2021
View reviewed changes
Copy link
Member

@Mohitmadhav Mohitmadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AryanKhubchandani for resolving the null error:

  • flutter clean
  • flutter packages get
  • git pull upstream main

The dialog is loading in my local system. You do this and then notify me.

@AryanKhubchandani
Copy link
Contributor Author

@Mohitmadhav I tried this before too, the error persists.

@Mohitmadhav
Copy link
Member

@Mohitmadhav I tried this before too, the error persists.

I updated the main branch yesterday, didn't you get the changes in some files?

@AryanKhubchandani
Copy link
Contributor Author

@Mohitmadhav I tried this before too, the error persists.

I updated the main branch yesterday, didn't you get the changes in some files?

Yes I did get some changes, but the error still exists.

@Mohitmadhav
Copy link
Member

image
Screenshot (1533)

@AryanKhubchandani I switched to your branch and it opened this time.
And please remove the black color of Forgot your Password button

Once clean your app cache and uninstall it.
If it persists this time, we'll sort it out.

@AryanKhubchandani
Copy link
Contributor Author

image Screenshot (1533)

@AryanKhubchandani I switched to your branch and it opened this time. And please remove the black color of Forgot your Password button

Once clean your app cache and uninstall it. If it persists this time, we'll sort it out.

Sure, I will update you regarding the same. Thanks!

@AryanKhubchandani
Copy link
Contributor Author

The issue still exists for some reason :/

@Mohitmadhav
Copy link
Member

The issue still exists for some reason :/

Send the debug console screenshot here

@AryanKhubchandani
Copy link
Contributor Author

image

@Mohitmadhav
Copy link
Member

Now check @AryanKhubchandani , I have resolved the conflicts
Also resolve that Forgot your password button too, it wasn't like that before.

@AryanKhubchandani
Copy link
Contributor Author

Now check @AryanKhubchandani , I have resolved the conflicts Also resolve that Forgot your password button too, it wasn't like that before.

Yeah I fixed the button, will push the changes once I am done with the user preferences too

@Mohitmadhav
Copy link
Member

@AryanKhubchandani now are you able to click Personalize button?

@AryanKhubchandani
Copy link
Contributor Author

@AryanKhubchandani now are you able to click Personalize button?

No, haha. Something is still wrong. Nonetheless, I fixed the color of both the button and the choice chips. Please check for review.

@Mohitmadhav Mohitmadhav added the hacktoberfest-accepted Approval of PR in Hacktober fest label Oct 7, 2021
@Mohitmadhav Mohitmadhav merged commit 40f6e7d into Project-Easter:main Oct 7, 2021
@Mohitmadhav
Copy link
Member

@AryanKhubchandani now you can delete your branch and create another one and check after git pull upstream main because it's working all right in the main branch.

@AryanKhubchandani
Copy link
Contributor Author

@AryanKhubchandani now you can delete your branch and create another one and check after git pull upstream main because it's working all right in the main branch.

Alright, I will give it a try!

@Mohitmadhav Mohitmadhav linked an issue Oct 8, 2021 that may be closed by this pull request
Change Light Theme Color scheme #86
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohitmadhav Mohitmadhav Mohitmadhav approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Light Theme Color scheme
2 participants
@AryanKhubchandani @Mohitmadhav