Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add signup with email #93

Merged
merged 3 commits into from
Oct 2, 2021
Merged

Conversation

keyurgit45
Copy link
Contributor

Description

Summary of the changes and which issue is fixed.
I have added sign-up with email and password (firebase). The code for the same is in lib\screens\auth. Added validation for email and password. Also modified the Custom TextEditingField to use textEditingController in order to use the email and password for further sign-up use.

Fixes #83

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • [x]My code follows the code of conduct of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@keyurgit45
Copy link
Contributor Author

Github is showing the branch has some conflicts. but if i remove the code it will give error. what should i do ? @Mohitmadhav

@Mohitmadhav
Copy link
Member

Github is showing the branch has some conflicts. but if i remove the code it will give error. what should i do ? @Mohitmadhav

Did you do git pull upstream main before pushing your changes?

@Mohitmadhav
Copy link
Member

Github is showing the branch has some conflicts. but if i remove the code it will give error. what should i do ? @Mohitmadhav

Github is showing the branch has some conflicts. but if i remove the code it will give error. what should i do ? @Mohitmadhav

image
Is this the only conflict showing to you?

@keyurgit45
Copy link
Contributor Author

yes this is the only conflict showing to me.

@Mohitmadhav
Copy link
Member

Github is showing the branch has some conflicts. but if i remove the code it will give error. what should i do ? @Mohitmadhav

Did you do git pull upstream main before pushing your changes?

@keyurgit45 ?

@keyurgit45
Copy link
Contributor Author

keyurgit45 commented Oct 2, 2021

I did. But i got this ->
$ git pull upstream main
fatal: 'upstream' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

So I did git pull origin main and I got ->
From https://github.com/keyurgit45/Flutter-UI

  • branch main -> FETCH_HEAD
    Already up to date.

@Mohitmadhav
Copy link
Member

fatal: 'upstream' does not appear to be a git repository
fatal: Could not read from remote repository.

try out
git remote add upstream https://github.com/Project-Easter/Flutter-UI

Then again git pull upstream main

@Mohitmadhav
Copy link
Member

Mohitmadhav commented Oct 2, 2021

@keyurgit45
Copy link
Contributor Author

keyurgit45 commented Oct 2, 2021

I implemented sign up with Email not login. Also the app is missing log out feature.

@Mohitmadhav
Copy link
Member

I implemented sign up with Email not login. Also the app is missing log out feature.

Yeah, I assigned Google Sign out to someone else.
Also, I was creating another issue for login and logout so you can work on that too if you want.

@keyurgit45
Copy link
Contributor Author

I implemented sign up with Email not login. Also the app is missing log out feature.

Yeah, I assigned Google Sign out to someone else. Also, I was creating another issue for login and logout so you can work on that too if you want.

Sure, I would Like to work on them.

@Mohitmadhav
Copy link
Member

I implemented sign up with Email not login. Also the app is missing log out feature.

Yeah, I assigned Google Sign out to someone else. Also, I was creating another issue for login and logout so you can work on that too if you want.

Sure, I would Like to work on them.

Cool, the issue will be ready within a few minutes.

@keyurgit45
Copy link
Contributor Author

I implemented sign up with Email not login. Also the app is missing log out feature.

Yeah, I assigned Google Sign out to someone else. Also, I was creating another issue for login and logout so you can work on that too if you want.

Sure, I would Like to work on them.

Cool, the issue will be ready within a few minutes.

Thank you for your help. This is my first open-source contribution. Also, can you remove my email id's from firebase that I used for testing purpose?

@Mohitmadhav Mohitmadhav merged commit 578ae60 into Project-Easter:main Oct 2, 2021
@Mohitmadhav
Copy link
Member

I implemented sign up with Email not login. Also the app is missing log out feature.

Yeah, I assigned Google Sign out to someone else. Also, I was creating another issue for login and logout so you can work on that too if you want.

Sure, I would Like to work on them.

Cool, the issue will be ready within a few minutes.

Thank you for your help. This is my first open-source contribution. Also, can you remove my email id's from firebase that I used for testing purpose?

No problem bro.
Sure, will remove those email ids from firebase.

@Mohitmadhav Mohitmadhav added the hacktoberfest-accepted Approval of PR in Hacktober fest label Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email Authentication using Provider and Firebase
2 participants