Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified button #84

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Modified button #84

merged 1 commit into from
Oct 2, 2021

Conversation

Sayam06
Copy link
Contributor

@Sayam06 Sayam06 commented Oct 1, 2021 •
edited by Mohitmadhav
Loading

Description

Summary of the changes and which issue is fixed.

Fixes #82, removed facebook button and added google button.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the code of conduct of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings.

@Mohitmadhav
Copy link
Member

@Sayam06 please comment on the issue first to get yourselves assigned.

@Sayam06
Copy link
Contributor Author

Sayam06 commented Oct 2, 2021

can i please work on this issue?

@Mohitmadhav
Copy link
Member

@Sayam06 , Read the guidelines and comment on the issue, tagging me. I'll assign you and check the PR

@Mohitmadhav
Copy link
Member

Removed the Facebook button and modified the google button.

@Sayam06 please follow the PR template and edit your submission. The PR is fine

@Sayam06
Copy link
Contributor Author

Sayam06 commented Oct 2, 2021

Removed the Facebook button and modified the google button.

@Sayam06 please follow the PR template and edit your submission. The PR is fine

@Mohitmadhav can you tell me where I can find the template? Or should I create a new PR to get the template?

@Mohitmadhav
Copy link
Member

Mohitmadhav commented Oct 2, 2021 •
edited
Loading

Removed the Facebook button and modified the google button.

@Sayam06 please follow the PR template and edit your submission. The PR is fine

@Mohitmadhav can you tell me where I can find the template? Or should I create a new PR to get the template?

While creating a new pull request, you'll see the format
Then copy-paste that format in this PR.
No need to create a new PR, just copy the format

Something like this:
image

@Sayam06
Copy link
Contributor Author

Sayam06 commented Oct 2, 2021

@Mohitmadhav is this okay? None of the options in "Type of change" were applicable so I left them blank.

@Mohitmadhav
Copy link
Member

Cool @Sayam06!! But from now on, strictly follow the linting rules and standard practices to avoid warnings.
For more details see: analysis_options.yaml
I'm merging this PR.

@Mohitmadhav Mohitmadhav merged commit 4c0310c into Project-Easter:main Oct 2, 2021
@Mohitmadhav
Copy link
Member

@Mohitmadhav is this okay? None of the options in "Type of change" were applicable so I left them blank.

No problem, I mentioned it.

@Mohitmadhav Mohitmadhav added easy Easy level issue good first issue good issue for first-time contributors hacktoberfest-accepted Approval of PR in Hacktober fest labels Oct 2, 2021
@Sayam06
Copy link
Contributor Author

Sayam06 commented Oct 2, 2021

Cool @Sayam06!! But from now on, strictly follow the linting rules and standard practices to avoid warnings. For more details see: analysis_options.yaml I'm merging this PR.

Thanks :)
And sure, I'll follow the standard practices next time.
Cheers!!

@Mohitmadhav
Copy link
Member

Cool @Sayam06!! But from now on, strictly follow the linting rules and standard practices to avoid warnings. For more details see: analysis_options.yaml I'm merging this PR.

Thanks :) And sure, I'll follow the standard practices next time. Cheers!!

Yeah, more issues will be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
easy Easy level issue good first issue good issue for first-time contributors hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Google Sign In button
2 participants
@Sayam06 @Mohitmadhav