Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location update without tapping twice #128

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

kshitij5
Copy link
Contributor

@kshitij5 kshitij5 commented Oct 6, 2021

Description

This PR fixes issue #112 and as a result, the user doesn't need to click twice to update his current location. Now, the same can be achieved just by single tapping on the Floating Action Button!

Screenshots below:
Screenshot_1633512124
Screenshot_1633524566

I think we don't need to navigate to the map page anymore since we aren't allowing users to manually change the location!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code of conduct of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@kshitij5 kshitij5 changed the title Location update without tapping twice #112 Location update without tapping twice Oct 6, 2021
Copy link
Member

@Mohitmadhav Mohitmadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Cool @kshitij5
Make sure to follow standard practices as shown in the screenshot.
Rest everything is fine.

@Mohitmadhav Mohitmadhav linked an issue Oct 6, 2021 that may be closed by this pull request
@Mohitmadhav Mohitmadhav added the hacktoberfest-accepted Approval of PR in Hacktober fest label Oct 6, 2021
@Mohitmadhav Mohitmadhav merged commit 780ed5b into Project-Easter:main Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Location update without tapping twice
2 participants