Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOCUS update on 07/20/2017 #13

Closed
zhucaoxiang opened this issue Jul 20, 2017 · 3 comments
Closed

FOCUS update on 07/20/2017 #13

zhucaoxiang opened this issue Jul 20, 2017 · 3 comments
Assignees

Comments

@zhucaoxiang
Copy link
Collaborator

Dear all,

I pushed several updates in both 'master' and 'develop' branches. Here are the key points:

  • Add options to freely control the optimization focus : currents or geometries
    The two input namelist weight_Inorm and weight_Gnorm are added. Thanks to @logan-nc , the details can be seen in pull_12.

  • Add additional criteria to exit optimizations
    The new input variable exit_tol could be used to exit from the running optimizations when the relative change of last 5 outputs is small than exit_tol. By default, it's 1.0E-04. You can use this to accelerate your jobs. Refer to initial.pdf.

  • Replace the repeated output information in CG
    Now the second column of output information when using CG is the time from the start of optimization. Just for a reference. Any other informations can be added.

    And, the bug that wrong cpu time is shown when using gfortran compiler is now fixed by replacing include "mpif.h" with use mpi.

  • fixed other minor stuffs

If you have any questions, please let me know. Thanks!

@logan-nc
Copy link
Collaborator

Cool. At this point, with multiple people following/using FOCUS, you might want to consider using releases instead of these issues to record significant steps in the development.

I've sent it before, but I still recomend the suggestion on https://nvie.com/posts/a-successful-git-branching-model/ of releasing ever time you push to master (excepting accidents like when I made the norm pull request to master instead of develop). As per the semantic versioning standards (https://semver.org/) you would start with release 0.1.0. This way, assuming you include the version in the h5 output, you can go back and checkout the version you used to run something when coming back to it a year from now.

@zhucaoxiang
Copy link
Collaborator Author

@logan-nc Nice suggestion! I intended to push the develops in 'develop' branch and then found the 'norm' branch was merged into 'master'. In the future, I will pay more attention on this. And maybe a wiki page is better for recording the updates.

@logan-nc
Copy link
Collaborator

Don't be afraid of just using lots of releases:
https://github.com/gafusion/OMFIT-source/releases

Current chrome release: 59.0.3071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants