Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible minor issue in demos/unsteady_masked_galerkin_vs_lspg_advdiff1d_pod #26

Open
gokhalen opened this issue Nov 25, 2022 · 1 comment
Open

possible minor issue in demos/unsteady_masked_galerkin_vs_lspg_advdiff1d_pod #26

gokhalen opened this issue Nov 25, 2022 · 1 comment

Comments

@gokhalen
Copy link

Line 47 in advection_diffusion1d.py increments nGrid by 2.

Line 167 in main.py creates an advection_diffusion problem with meshSize=200. So internally AdvDiff1d is incrementing it to 202. On line 197 indices 0 and 199 are chosen as the boundary indices. Since there are 202 nodes shouldn't the boundary indices be 0 and 201 instead of 0 and 199?

Thanks,

Nachiket
@gokhalen gokhalen changed the title possible minor issue in possible minor issue in demos/unsteady_masked_galerkin_vs_lspg_advdiff1d_pod Nov 25, 2022
@fnrizzi
Copy link
Member

fnrizzi commented Jan 6, 2023

thanks for pointing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gokhalen @fnrizzi