Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-based development environment #3

Merged
merged 1 commit into from
Nov 2, 2016

Conversation

danguita
Copy link
Contributor

@danguita danguita commented Nov 2, 2016

This PR provides Docker based development environment starting point as an alternative to the current one.

Summary of changes:

  • Manage containers via Docker Compose.
  • Make any configuration environment dependent.
  • Add some starting /script commands.
  • Add MailCatcher container and configuration.
  • Add proper docs.

@danguita danguita force-pushed the support/docker-development-env branch 2 times, most recently from 3f5ba56 to a168f07 Compare November 2, 2016 13:54
@@ -0,0 +1,6 @@
FROM ruby:2.3.1
MAINTAINER Populate <[email protected]>
Copy link
Contributor Author

@danguita danguita Nov 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ferblape Which would be a good maintainer's email?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say Populate <[email protected]>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Let me take care.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are squashed already.

- Manage containers via Docker Compose.
- Make any configuration environment dependent.
- Add some starting `/script` commands.
- Add MailCatcher container and configuration.
- Add docs.
@danguita danguita force-pushed the support/docker-development-env branch from a168f07 to 759c6b5 Compare November 2, 2016 14:01
@ferblape
Copy link
Member

ferblape commented Nov 2, 2016

👍

@ferblape ferblape merged commit fc1fc24 into master Nov 2, 2016
@danguita danguita deleted the support/docker-development-env branch November 2, 2016 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants