Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Digester on deleted elements #730

Open
ferblape opened this issue Jun 1, 2017 · 1 comment
Open

Notification Digester on deleted elements #730

ferblape opened this issue Jun 1, 2017 · 1 comment
Labels

Comments

@ferblape
Copy link
Member

ferblape commented Jun 1, 2017

When sending periodic notifications (each hour, day or week) the process building the URLs needs to take into account which elements from the notification have been removed, so they need to be ignored and not included in the body of the email.

https://github.com/PopulateTools/gobierto/blob/master/app/decorators/user_notification_decorator.rb#L21

Rollbar: https://rollbar.com/fernando/gobierto/items/420/

@ferblape ferblape added the bug label Jun 1, 2017
@ferblape
Copy link
Member Author

ferblape commented Jun 3, 2017

  • cron task that removes user notifications with nil subject in the last 2 hours
  • run the task every hour
  • fix the code for real time deliveries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant