Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of Sidekiq retries #684

Closed
ferblape opened this issue Apr 28, 2017 · 3 comments
Closed

Limit the number of Sidekiq retries #684

ferblape opened this issue Apr 28, 2017 · 3 comments

Comments

@ferblape
Copy link
Member

10 retries should be enough, and if possible, each one delayed from the other as Delayed Job does.

@bertocq
Copy link
Contributor

bertocq commented May 10, 2017

I haven't found any way to specify a max number of retries globally, seems like it has to be specified on each worker sidekiq_options line (https://github.com/mperham/sidekiq/wiki/Error-Handling#configuration), although having a global variable to hold that number would be good idea to change it afterwards all at once.

About the delays between retries, it does them exponentially by default https://github.com/mperham/sidekiq/wiki/Error-Handling#automatic-job-retry

I've only found one job https://github.com/PopulateTools/gobierto/blob/9129855c0f81a705ac5c154dfd35e8e011abd069/app/jobs/user/verification_job.rb But I don't see the include Sidekiq::Worker on it, are you sure you're using Sidekiq on it? Maybe the inheritance from ActiveJob::Base does it and I'm doing a stupid question :)

@ferblape
Copy link
Member Author

I think you are right @bertocq: there's no a global way to specify what I want.

We use ActiveJob with Sidekiq as backend, that's why you don't find any Worker. And our main issue is with Algolia, which uses jobs to synchronize with the server in an asynchronous fashion.

@ferblape
Copy link
Member Author

Discarded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants