Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3935 visualizations homepage #3937

Merged
merged 6 commits into from
Sep 14, 2021
Merged

Conversation

entantoencuanto
Copy link
Member

@entantoencuanto entantoencuanto commented Sep 8, 2021

Closes #3935

✌️ What does this PR do?

  • Changes the visualizations module to take the module root path from the module configuration. To set a visualization as the home include a "home": true option in its configuration. Note that if several visualizations are configured as home, only the first one will be taken into account.
  • Adds an integration test
  • Adds a fix to avoid exceptions if a path is requested for a visualization not configured in the module settings
  • Adds the route '/' to visualizations homepage. [front]

🔍 How should this be manually tested?

Configure GobiertoVisualizations as the home module in the site.
Change the module settings and include in a visualization the "home": true setting
staging

👀 Screenshots

Before this PR

After this PR

:shipit: Does this PR changes any configuration file?

No

(Changes in these files might need to update the role in Ansible)

📖 Does this PR require updating the documentation?

Suggestion added to gobierto.readme.io

@furilo
Copy link
Member

furilo commented Sep 8, 2021

OK on my part.

@entantoencuanto entantoencuanto marked this pull request as ready for review September 8, 2021 19:43
Copy link
Member

@ferblape ferblape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to me! @entantoencuanto feel free to deploy

@entantoencuanto entantoencuanto merged commit f9462ac into master Sep 14, 2021
@entantoencuanto entantoencuanto deleted the 3935-visualizations_homepage branch September 14, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualizations / Enable this module as the home page of a site
4 participants