-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filters sidebar #3928
Labels
Comments
The wrapper component is done in #3934
|
Since the wrapper component also deal with the routes, the gobierto_data implementation won't be so straightforward as initially was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently there are several implementations of the filters sidebar along Gobierto app. They're all slightly differents each other, but some of them can be merged.
The best approach due to its isolation, loose coupling, high cohesion and simplicity is at vue/mixins (code will be brought to gobierto base shortly).
Regarding gobierto-data the refactor will be quite simple, as such module was using a needless property there (
store
)Regarding gobierto-investments will be little trickier, as the
store
property (perhaps no longer necessary) is pretty binded all through the moduleRegarding gobierto-visualizations will require a further look, as the filters trigger events also, in order to make dc.js listening such events
Once we have some shared, working code, it could be wrapped into a Vue component to create the default filters sidebar when no specific HTML/CSS is required (currently you choose what inner components will render)
Related to https://github.com/PopulateTools/issues/issues/1208
The text was updated successfully, but these errors were encountered: