Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters sidebar #3928

Open
Crashillo opened this issue Aug 27, 2021 · 2 comments
Open

Filters sidebar #3928

Crashillo opened this issue Aug 27, 2021 · 2 comments
Assignees
Labels

Comments

@Crashillo
Copy link
Member

Crashillo commented Aug 27, 2021

Currently there are several implementations of the filters sidebar along Gobierto app. They're all slightly differents each other, but some of them can be merged.

  • investments
  • data
  • visualizations
  • documents (engine)

The best approach due to its isolation, loose coupling, high cohesion and simplicity is at vue/mixins (code will be brought to gobierto base shortly).

Regarding gobierto-data the refactor will be quite simple, as such module was using a needless property there (store)

Regarding gobierto-investments will be little trickier, as the store property (perhaps no longer necessary) is pretty binded all through the module

Regarding gobierto-visualizations will require a further look, as the filters trigger events also, in order to make dc.js listening such events

Once we have some shared, working code, it could be wrapped into a Vue component to create the default filters sidebar when no specific HTML/CSS is required (currently you choose what inner components will render)

Related to https://github.com/PopulateTools/issues/issues/1208

@Crashillo
Copy link
Member Author

Crashillo commented Sep 3, 2021

The wrapper component is done in #3934
Modules to update:

@Crashillo
Copy link
Member Author

Since the wrapper component also deal with the routes, the gobierto_data implementation won't be so straightforward as initially was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants