Hi!, @ferblape about

about this test this should be (2 preferred)

1. removed
2. replaced for another model ¿why model can I use?

what's about GobiertoAttachment::AttachmentDocumentsController? Does it make sense without GobiertoParticipations::Process?

thx

@blat I have a problem with a test that before works and not now ... I am missing something...

an example of dependant level with animals and dog fixtures level is (note line 19 below)

but into all term.yml there are single culture_term

1. I propose change:

# change this
  def test_destroy_of_term_with_dependencies
    terms_with_dependencies.each do |_, term|
      refute term.destroy
    end
  end

# to this
  def test_destroy_of_term_with_dependencies
    refute root_level_term.destroy
  end

But I have a worse problem the decorator don't detect terms collection here

TermDependendentResourceDecorator is not enough. I need add some changes at:

2. I propose add new case to dependant

def destroy
      dependent_resources_decorator = TermDependentResourcesDecorator.new(self)
      if dependent_resources_decorator.has_dependent_resources?
        errors.add(:base, :has_dependent_resources_html, dependencies_list: dependent_resources_decorator.dependencies_list)
        return false
      elsif !terms.empty?
        errors.add(:base, :has_dependent_resources_html, dependencies_list: "term_id")
        return false
      end

      super
    end

What am I missing?

should I delete (full) or refactor this decorator and its test? . I am not sure about because it looks like a feature into GobiertoCMS designed to be used by GobiertoParticipations.

So with participation deleted. Does it keeping sense?

thx

Hmmmm, not exactly, that decorator is used to customize GobiertoCms::Pages, which are used in participation module but also in other modules. So leave the decorator and update the test to remove the relative to themes.

what about this test? should I delete it or where should I redirect path instead of admin_participation_process_pages_path(process.id)

thx

hi, just to confirm, the test into this folder https://github.com/PopulateTools/gobierto/tree/master/test/integration/gobierto_admin/gobierto_attachments are dependent of some fixtures of GobiertoParticipations.

Should I refactor or delete?

thx

After the module deletion the class GobiertoParticipation::Process is undefined and migration will fail. How I should fix this?

• keep migration implicated but surrounded by if defined?
• removing the content of migration method affected?

Just to say, there are 4 cases of migrations like this

Thx

Good point, using if defined? sounds good to me

Should join fixtures and fixtures_archive? at least which that are still in use ... or I'm missing something?

thx!

So attachment and participation have a set of test cases which I need remove or rewrite as new feature. Some details:

before deletion module attachment show the collection and attachments that belongs to GobiertoParticipation::Process. These process can be archived with paranoid and then these collections were not show.

I think that this behavior don't apply to attachment collections which don't belongs to Process:

• I searched examples into staging admin/attachments/file_attachments
• then archive all attachment into a collection
• the collection it keep showing (I think that it's right)

therefore this test should be removed, or I am missing something?
thx

that was my first step. OkI will separate into different commit to speak about later

thx

I'm having problems passing test of gobierto_engine_gencat so I found this js errors, into my local env and also into staging

@entantoencuanto please continue the work of Esteban in this PR, he's commenting about some errors in gencat engine tests, but it's weird because participation and gencat are not related and don't share code.