Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search method test coverage #3365

Closed
ferblape opened this issue Sep 22, 2020 · 1 comment · Fixed by #3367
Closed

Search method test coverage #3365

ferblape opened this issue Sep 22, 2020 · 1 comment · Fixed by #3367
Assignees

Comments

@ferblape
Copy link
Member

@entantoencuanto I've just discovered that this version of pg_search introduces a bug in the search method, which is causing a 500 error in Gobierto: https://appsignal.com/populate/sites/5ebb88520264445dc7e68b5c/exceptions/incidents/244?timestamp=2020-09-22T13%3A07%3A10Z

But the tests are green, please review the coverage of the search methods and review why we couldn't detect this error in the test suite. Version 2.3.2 works fine.

And meanwhile, restore 2.3.2 version and freeze it

@entantoencuanto
Copy link
Member

Hmm, there were a missing integration test. Added to PR, it fails with 2.3.3 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants