3222 spread custom fields api optimization #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…controller actions
Codecov Report
@@ Coverage Diff @@
## master #3283 +/- ##
=======================================
Coverage 84.76% 84.77%
=======================================
Files 804 804
Lines 21275 21277 +2
=======================================
+ Hits 18034 18037 +3
+ Misses 3241 3240 -1
Continue to review full report at Codecov.
|
|
Please, @Crashillo, could you review the js changes before I merge into staging? |
Crashillo
requested changes
Aug 6, 2020
| @@ -374,8 +374,9 @@ export default { | |||
| // Get the items based on these new active filters | |||
| const __items__ = this.applyFiltersCallbacks(__activeFilters__); | |||
|
|
|||
| return __items__.filter(({ attributes }) => | |||
| attributes[key].map(g => g.id).includes(id) | |||
| return __items__.filter(({ attributes }) =>( | |||
There was a problem hiding this comment.
You may get rid of the wrapping parenthesis, in the filter condition
Co-authored-by: Hugoren Martinako <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3222
✌️ What does this PR do?
🔍 How should this be manually tested?
Visit affected modules. Nothing should change
No
(Changes in these files might need to update the role in Ansible)
📖 Does this PR require updating the documentation?
No