Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing data declaration. Fixing test with it. #3089

Closed
wants to merge 1 commit into from
Closed

Adding missing data declaration. Fixing test with it. #3089

wants to merge 1 commit into from

Conversation

eltercero
Copy link
Member

Closes #3088

✌️ What does this PR do?

Fixes a failing test from the dashboards module.

:shipit: Does this PR changes any configuration file?

No

📖 Does this PR require updating the documentation?

No

@eltercero eltercero requested a review from ferblape May 21, 2020 06:20
@ferblape
Copy link
Member

I'm seeing tests failing in my local environment.

Sometimes 2:

Failure:
GobiertoDashboards::DashboardsContractsTest#test_summary [/Users/fernando/proyectos/gobierto/test/integration/gobierto_dashboards/dashboards_contracts_test.rb:68]
Minitest::Assertion: Expected false to be truthy.

Failure:
GobiertoDashboards::DashboardsContractsTest#test_tenders [/Users/fernando/proyectos/gobierto/test/integration/gobierto_dashboards/dashboards_contracts_test.rb:180]
Minitest::Assertion: Expected false to be truthy.

And sometimes 3:

Failure:
GobiertoDashboards::DashboardsContractsTest#test_summary [/Users/fernando/proyectos/gobierto/test/integration/gobierto_dashboards/dashboards_contracts_test.rb:68]
Minitest::Assertion: Expected false to be truthy.

Failure:
GobiertoDashboards::DashboardsContractsTest#test_tenders [/Users/fernando/proyectos/gobierto/test/integration/gobierto_dashboards/dashboards_contracts_test.rb:180]
Minitest::Assertion: Expected false to be truthy.

Failure:
GobiertoDashboards::DashboardsContractsTest#test_contracts [/Users/fernando/proyectos/gobierto/test/integration/gobierto_dashboards/dashboards_contracts_test.rb:94]
Minitest::Assertion: Expected false to be truthy.

@eltercero
Copy link
Member Author

@ferblape I can't seem to reproduce those failures, it always passes all the tests for me. Is this the first time you run them? If not, have they passed before?

@ferblape
Copy link
Member

Yes, it's the first time I run them. I've just checked out your branch and executed them

@eltercero
Copy link
Member Author

@ferblape so, this test was fixed after merging #3063 (I noticed the missing data declaration there a few days ago 3488a27), so this PR is not really neccesary anymore. Tests seems to pass now in master.

About the failures, sometimes the first couple of times (usually just the first time) they fail because the assets didn't fully compile for the test (it happnes to me too). Could that be the case?

@ferblape
Copy link
Member

Maybe, if master is fine now, then let's close this. Thanks!

@eltercero eltercero closed this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferblape ferblape Awaiting requested review from ferblape

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GobiertoDashboards::DashboardsContractsTest#test_contracts
2 participants
@eltercero @ferblape