Contracts dashboards: assignees ranking #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov Report
@@ Coverage Diff @@
## master #3075 +/- ##
=======================================
Coverage 77.42% 77.42%
=======================================
Files 788 788
Lines 21294 21294
=======================================
Hits 16486 16486
Misses 4808 4808 Continue to review full report at Codecov.
|
7 tasks
eltercero
force-pushed
the
3046-assignees-ranking
branch
from
19941f0
to
acb5028
Compare
ferblape
approved these changes
May 19, 2020
|
Is this another topic branch? I added a |
…reusable when filtering
Added new generic modules for the charts
They were broken after changing 1) tenders/contracts default order and 2) only making calculations only with formalized contracts.
keep-alive was being rendered twice and cache was happening twice.
…ntractsIndex and TendersIndex Also, aligning quantity columns to the right.
eltercero
force-pushed
the
3046-assignees-ranking
branch
from
8edd2f1
to
71e0b01
Compare
|
@Crashillo this can now be reviewed 👍 |
Crashillo
requested changes
May 21, 2020
app/javascript/gobierto_dashboards/modules/contracts_controller.js
Outdated
Show resolved
Hide resolved
app/javascript/gobierto_dashboards/modules/contracts_controller.js
Outdated
Show resolved
Hide resolved
app/javascript/gobierto_dashboards/modules/contracts_controller.js
Outdated
Show resolved
Hide resolved
app/javascript/gobierto_dashboards/webapp/containers/contract/ContractsShow.vue
Outdated
Show resolved
Hide resolved
app/javascript/gobierto_dashboards/webapp/containers/summary/Summary.vue
Show resolved
Hide resolved
app/javascript/gobierto_dashboards/webapp/containers/summary/Summary.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Hugoren Martinako <[email protected]>
…ierto into 3046-assignees-ranking
Crashillo
approved these changes
May 22, 2020
app/javascript/gobierto_dashboards/webapp/containers/contract/ContractsShow.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Hugoren Martinako <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3046
✌️ What does this PR do?
It mainly adds the assignees ranking to the Dashboards contracts summary page. It should refresh along with the bar charts filters.
Along with that, it also includes the following fixes and features:
🔍 How should this be manually tested?
It can be tested from the main summary page. It's been deployed to staing https://burjassot.gobify.net/dashboards/contratos/resumen
👀 Screenshots
.env.example?config/application.yml?config/secrets.yml?(Changes in these files might need to update the role in Ansible)
📖 Does this PR require updating the documentation?