Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLEditorResults does know nothing about what Visualizations does #3023

Open
Crashillo opened this issue May 5, 2020 · 1 comment
Open

SQLEditorResults does know nothing about what Visualizations does #3023

Crashillo opened this issue May 5, 2020 · 1 comment
Assignees
@jorgeatgu

Comments

@Crashillo
Copy link
Member

What are this Visualizations functions doing enclosed here? You're messing with the logic. SQLEditorResults does know nothing about what Visualizations does. The parent just "inform" the children about showing/hiding, nothing else.
These functions does not belong here.

Originally posted by @Crashillo in https://github.com/PopulateTools/gobierto/diffs
@Crashillo Crashillo changed the title What are this Visualizations functions doing enclosed here? You're messing with the logic. SQLEditorResults does know nothing about what Visualizations does. The parent just "inform" the children about showing/hiding, nothing else. SQLEditorResults does know nothing about what Visualizations does May 5, 2020
@ferblape
Copy link
Member

@jorgeatgu is this still relevant or did you refactor the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgeatgu jorgeatgu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ferblape @Crashillo @jorgeatgu