2957 append data to table using existing schema #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good. Let me know when it's available in staging because I need it for a few datasets 🎸 |
|
Ready in staging! |
ferblape
reviewed
Apr 16, 2020
| @@ -57,7 +57,7 @@ def complete_schema_with_defaults(source_file, schema_definition) | |||
| default_schema = inspect_csv_schema(source_file, csv_separator: @csv_separator) | |||
| schema_definition = (schema_definition || {}).deep_symbolize_keys | |||
| default_schema.map do |default_column, default_value| | |||
| schema_definition.find { |_, value| value[:original_name] == default_value[:original_name] } || [default_column, default_value] | |||
| schema_definition.find { |_, value| value[:original_name].casecmp?(default_value[:original_name]) } || [default_column, default_value] | |||
There was a problem hiding this comment.
Why the original_name is mandatory? I think it should be optional if the name doesn't change
There was a problem hiding this comment.
Changed, now this attribute can be omitted
houndci-bot
reviewed
Apr 16, 2020
| # | ||
| def test_dataset_update_with_file_upload_append_with_schema | ||
| with(site: site) do | ||
| with_stubbed_jwt_default_secret(default_secret) do |
| # PUT /api/v1/data/datasets/dataset-slug | ||
| # | ||
| def test_dataset_update_with_file_upload_append_with_schema | ||
| with(site: site) do |
| # PUT /api/v1/data/datasets/dataset-slug | ||
| # | ||
| def test_dataset_update_with_file_upload_append | ||
| with(site: site) do |
| # PUT /api/v1/data/datasets/dataset-slug | ||
| # | ||
| def test_dataset_update_with_file_upload | ||
| with(site: site) do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2957
✌️ What does this PR do?
original_namein schema JSON file. If omitted it's assumed that theoriginal_namethe same as the destination nameNo
(Changes in these files might need to update the role in Ansible)
📖 Does this PR require updating the documentation?
No