Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seed recipe of gobierto data with default custom fields #2849

Merged
merged 2 commits into from
Feb 12, 2020

Conversation

entantoencuanto
Copy link
Member

Closes #2837

✌️ What does this PR do?

  • Adds 3 default custom fields (if not already present) for datasets when module is enabled:
    • Description: text with translations
    • Frequency: vocabulary options
    • Category: vocabulary options

WIP: Currently the category is generated with a vocabulary with only a "General" term, but may another better defaults should be used after #2671 research

:shipit: Does this PR changes any configuration file?

No

(Changes in these files might need to update the role in Ansible)

📖 Does this PR require updating the documentation?

No

@codecov-io
Copy link

codecov-io commented Feb 7, 2020

Codecov Report

Merging #2849 into master will decrease coverage by 5.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2849      +/-   ##
==========================================
- Coverage   83.74%   78.16%   -5.58%     
==========================================
  Files         773      771       -2     
  Lines       20298    20622     +324     
==========================================
- Hits        16998    16119     -879     
- Misses       3300     4503    +1203
Impacted Files Coverage Δ
...p/forms/gobierto_admin/admin_edit_password_form.rb 0% <0%> (-100%) ⬇️
.../policies/gobierto_participation/comment_policy.rb 0% <0%> (-100%) ⬇️
...ntrollers/gobierto_data/api/v1/query_controller.rb 0% <0%> (-100%) ⬇️
app/mailers/gobierto_budgets/feedback_mailer.rb 0% <0%> (-100%) ⬇️
...gobierto_citizens_charters/commitment_decorator.rb 0% <0%> (-100%) ⬇️
...gobierto_data/configuration/settings_controller.rb 0% <0%> (-100%) ⬇️
.../services/gobierto_common/active_notifier/daily.rb 0% <0%> (-100%) ⬇️
...ers/gobierto_observatory/application_controller.rb 0% <0%> (-100%) ⬇️
...admin/gobierto_calendars/collections_controller.rb 0% <0%> (-100%) ⬇️
...erto_admin/gobierto_common/api/terms_controller.rb 0% <0%> (-100%) ⬇️
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953f23a...120bbf5. Read the comment docs.

* Change default datasets categories
* Rename default vocabularies to include dataset name
@entantoencuanto entantoencuanto force-pushed the 2837-gobierto_data_default_custom_fields branch from a1a77b4 to 120bbf5 Compare February 12, 2020 11:39
@entantoencuanto entantoencuanto marked this pull request as ready for review February 12, 2020 13:04
@entantoencuanto entantoencuanto merged commit 68e1f44 into master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate description custom field creation on module setup
2 participants