Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lib/* pack #2638

Open
Crashillo opened this issue Oct 30, 2019 · 0 comments
Open

Refactor lib/* pack #2638

Crashillo opened this issue Oct 30, 2019 · 0 comments

Comments

@Crashillo
Copy link
Member

Currently we're importing lib/commons in all modules. That contains some generic libraries we must load to make the application run. For the time being, that's ok.

But, at the end, we're importing as well lib/shared, which brings a lot of dead code (JS that won't run in the current page) we actually don't need. As an example, we should copy the logic behind lib/visualizations where we're importing/exporting only those pieces of code we actually must load for the current site.

As a way to proceed, we should go module by module, from the latest (far easier) to the oldest (quite legacy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant