Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch budget lines last year with data #230

Open
ferblape opened this issue Jan 11, 2017 · 1 comment
Open

Fetch budget lines last year with data #230

ferblape opened this issue Jan 11, 2017 · 1 comment
Labels

Comments

@ferblape
Copy link
Member

Currently, the budget lines request in the Budget Consultations module searches budget lines for the current year. This is not totally correct, because we might not have data for this year yet.

This should be a decision taken by Populate Data, not by the API client. We have some plans in Populate Data on how to implement this, maybe by using a special value in the filter_by_date parameter.

@ferblape ferblape added the bug label Jan 11, 2017
@ferblape ferblape self-assigned this Jan 11, 2017
@danguita
Copy link
Contributor

danguita commented Jan 11, 2017

Just for the record, wanna add that the only service retrieving data through the PopulateData client is taking year as an argument, which defaults to system's year if not specified.

Having said that, how about defining a new setting via ENV to store the latest date (maybe just the year) available so that we can default to it in that service, or any coming?

Anyways, I agree to leave this decision to the API itself, taking into account when the request was done.

@ferblape ferblape added this to Back-log in Product roadmap Jan 26, 2017
@ferblape ferblape removed their assignment Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants