Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observatory card update info, not pulled to the right #2193

Closed
ferblape opened this issue Mar 27, 2019 · 4 comments · Fixed by #2273
Closed

Observatory card update info, not pulled to the right #2193

ferblape opened this issue Mar 27, 2019 · 4 comments · Fixed by #2273
Assignees

Comments

@ferblape
Copy link
Member

Screen Shot 2019-03-27 at 16 51 24

Looks like the updated date of a card is not being placed to the right. It uses the class pull-right but looks like that class has been lost in the CSS.

@ferblape
Copy link
Member Author

Also:

  1. Align the ? with the text
  2. Remove the underline between FB and Twitter icons?
  3. It looks like the source name and URL are not displayed now, but the data is in the JSON, investigate why:

Screen Shot 2019-04-29 at 10 50 13

@Crashillo
Copy link
Member

Crashillo commented Apr 30, 2019

pull-right class has been deprecated as of fontAwesome 4.4. It has been replaced by fa-pull-right

Further info: FortAwesome/Font-Awesome#12236

UPDATE
1 & 2 list-items will be solved then

@Crashillo
Copy link
Member

Crashillo commented May 3, 2019

Source name wasn't displayed because json.metadata.indicators has changed the key, from ["source name"] to ["source_name"]. Apparently, it doesn't affect anything else, but keep that in mind.
However, two new glitches have came up:

  1. Card bars breaks the layout when bars is too long
    imagen
  2. Population Pyramid is throwing a javascript error, so it's not displayed. I'm trying to figure out what's about.

Both errors could be checked at staging

@Crashillo
Copy link
Member

Crashillo commented May 3, 2019

Population Pyramid javascript error has been solved, but I think it's a workaround:
package.json now includes a "resolution" field, in order to force d3-selection to use 1.4.0 version. Check the commit:
https://github.com/PopulateTools/gobierto/pull/2273/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

Issue is due to yarn dependency resolver brought multiple d3-selection version, so it's required to set only one valid version. Check extra info here.

I think it's a workaround, as d3-selection may update someday. package.json resolutions field sets a static version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants