Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events date picker issues #1811

Closed
2 of 4 tasks
ferblape opened this issue Jul 27, 2018 · 3 comments
Closed
2 of 4 tasks

Events date picker issues #1811

ferblape opened this issue Jul 27, 2018 · 3 comments
Assignees

Comments

@ferblape
Copy link
Member

ferblape commented Jul 27, 2018

If you go to GobiertoPeople > Person > Agendas and edit an event:

  • it shows always the current time + the offset of the time zone. You can check this with any event in staging. If you edit and save the event it'll be recorded with a new time of + 2 hours, and so on

  • when you pick a day, the date picker closes. If you want to edit the hours too you need to open it again

  • could we make the input editable so no need to use the date picker? could we make the hours input editable?

  • it'd be great to link (bind) start and end dates for events and not for processes phases. So maybe we could think on a parameter that if active links the dates, otherwise it doesn't

@Crashillo
Copy link
Member

This helper solves the last point.

You only must identify which datepicker forms should have an offset value between start & end dates and edit those HTML using the helper

@ferblape
Copy link
Member Author

ferblape commented Aug 3, 2018

I don't see what you mean. Binded datepickers behaviour is implemented here: https://github.com/PopulateTools/gobierto/blob/master/app/javascript/admin/modules/application.js#L87-L93

This is what should be configurable via a parameter.

@ferblape
Copy link
Member Author

ferblape commented Aug 3, 2018

We'll solve the first point in #1837, it's a Ruby and Rails issue 💎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants