Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback from Algolia search #1449

Closed
ferblape opened this issue Feb 14, 2018 · 3 comments
Closed

Fallback from Algolia search #1449

ferblape opened this issue Feb 14, 2018 · 3 comments
Assignees

Comments

@ferblape
Copy link
Member

Algolia account shouldn't be mandatory in the budgets module.

When Algolia is not present, use the ES search implemented in the budgets explorer.

@amiedes
Copy link
Contributor

amiedes commented May 2, 2018

I've done this but I'm not sure if it's exactly what you want:

captura de pantalla 2018-05-02 a las 17 45 29

¿Do you want to keep this styling or adapt the one we use in Algoliasearch results?

¿What is the context of this feature? I don't see the use case for our Gobierto since it's already configured, ¿is it for D**A?

@ferblape
Copy link
Member Author

ferblape commented May 3, 2018

The context is: for some customers that won't use our cloud we don't want to setup Algolia or Amazon S3. So we want to be able to deactivate both features. For the files it's already implemented as a setting in the application.yml. The idea is to have a setting too for the search.

For the moment, the scope of the issue is to replace the search just for budgets module. We will need to decide what to do in the rest of modules. In budgets it's very easy to replace becaue we have this autocomplete.

What you have done looks good to me.

@furilo
Copy link
Member

furilo commented May 3, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants