Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Failure in test_floating_potential #2711

Closed
JaydenR2305 opened this issue Jun 3, 2024 · 2 comments · Fixed by #2710
Closed

Flaky Failure in test_floating_potential #2711

JaydenR2305 opened this issue Jun 3, 2024 · 2 comments · Fixed by #2710

Comments

@JaydenR2305
Copy link
Member

The test_floating_potential module occasionally emits a JSONDecodeError. See https://github.com/PlasmaPy/PlasmaPy/actions/runs/9352991385/job/25742427527#step:6:129

It is unclear which of the tests this error is originating from.. usually the console mentions this information?
@namurphy
Copy link
Member

namurphy commented Jun 3, 2024

Thank you for raising this!

📝 From the lower part of the error message, it looks like after the JSONDecodeError is raised, pytest-xdist is collecting different tests for different processes when collecting/running tests in parallel. Looking at the known limitations of pytest-xdist, I think that's happening as a consequence of the JSONDecodeError being raised and printing an error message to stdout. So, I suspect the problem with pytest-xdist test collection is secondary and will go away after the JSONDecodeError is fixed.

@JaydenR2305
Copy link
Member Author

Oh I think I see the issue. Look at https://github.com/PlasmaPy/PlasmaPy/actions/runs/9352991385/job/25742427527#step:6:43

@JaydenR2305 JaydenR2305 mentioned this issue Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Downloader Test Suite Resilient to ReadTimeout JaydenR2305/PlasmaPy
2 participants
@namurphy @JaydenR2305