Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes on notebook to documentation links to doc dev guide #1061

Open
Tracked by #1117
StanczakDominik opened this issue Mar 11, 2021 · 0 comments · May be fixed by #1381
Open
Tracked by #1117

Add notes on notebook to documentation links to doc dev guide #1061

StanczakDominik opened this issue Mar 11, 2021 · 0 comments · May be fixed by #1381
Labels
contributor guide docs PlasmaPy Docs at http:https://docs.plasmapy.org priority: high Issues & PRs with significant urgency and importance that should be addressed soon
Milestone

Comments

@StanczakDominik
Copy link
Member

To quote a great summary:


I think a developer docs page on how to do the links in notebooks is a good idea, since they really improve the documentation but are annoying to create! The learning curve is steep since you have to commit and wait for CI to run to get feedback on whether you're doing it correctly. For the record, here are three examples that finally worked:

For a function

[rot_a_to_b()]: ../api/plasmapy.formulary.mathematics.rot_a_to_b.rst#plasmapy.formulary.mathematics.rot_a_to_b

For a class

[SyntheticProtronRadiography]: ../api/plasmapy.diagnostics.proton_radiography.SyntheticProtonRadiograph.rst#plasmapy.diagnostics.proton_radiography.SyntheticProtonRadiograph

For a method of a class

[create_particles()]: 
../api/plasmapy.diagnostics.proton_radiography.SyntheticProtonRadiograph.rst#plasmapy.diagnostics.proton_radiography.SyntheticProtonRadiograph.create_particles

For an external website

[np.random.choice()]: https://numpy.org/doc/stable/reference/random/generated/numpy.random.choice.html

It would be worth explaining where the api/ files are created. These paths are relative to the main notebooks directory: if the notebook is in a sub folder (eg. cartesian_grids.ipynb which is in notebooks/plasma/) an additional ../ is required to get back to the api/ directory.

Originally posted by @pheuer in #1054 (comment)

@namurphy namurphy added the docs PlasmaPy Docs at http:https://docs.plasmapy.org label Jun 1, 2021
@namurphy namurphy added this to the 0.8.0 milestone Jul 20, 2021
@namurphy namurphy added the priority: high Issues & PRs with significant urgency and importance that should be addressed soon label Sep 9, 2021
@namurphy namurphy modified the milestones: 0.8.0, 0.9.0 Jun 28, 2022
@namurphy namurphy modified the milestones: 0.9.0, 0.10.0 Oct 27, 2022
@namurphy namurphy modified the milestones: 2023.1.0, 2023.5.0 Jan 9, 2023
@namurphy namurphy modified the milestones: 2023.5.0, 2023.9.0 May 12, 2023
@namurphy namurphy modified the milestones: 2023.10.0, v2024.1.0 Oct 22, 2023
@namurphy namurphy modified the milestones: v2024.2.0, Future Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor guide docs PlasmaPy Docs at http:https://docs.plasmapy.org priority: high Issues & PRs with significant urgency and importance that should be addressed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants