Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests for optimization subproblms #1208

Open
unalmis opened this issue Aug 20, 2024 · 0 comments
Open

More tests for optimization subproblms #1208

unalmis opened this issue Aug 20, 2024 · 0 comments
Labels
optimization Adding or improving optimization methods testing Adding a new test or fixing an existing one

Comments

@unalmis
Copy link
Collaborator

unalmis commented Aug 20, 2024 •
edited

We should add unit tests which check that the deterministic subproblems are solved correctly.

Right now, I only see optimization test for strictly convex functions in test_optimizer. A basic gradient descent would work for that; things could go wrong in more specialized methods that would not be detected by minimizing a convex function.

Originally posted by @unalmis in #1181 (review)
@unalmis unalmis added the testing Adding a new test or fixing an existing one label Aug 20, 2024
@unalmis unalmis changed the title Add tests for optimization subproblms More tests for optimization subproblms Aug 20, 2024
@dpanici dpanici added the optimization Adding or improving optimization methods label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimization Adding or improving optimization methods testing Adding a new test or fixing an existing one
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpanici @unalmis