Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Pytree input for coil objective targets and bounds #1152

Open
kianorr opened this issue Jul 26, 2024 · 3 comments
Open

Allow for Pytree input for coil objective targets and bounds #1152

kianorr opened this issue Jul 26, 2024 · 3 comments
Assignees
Labels
coil stuff relating to coils and coil optimization enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc interface New feature or request to make the code more usable or compatibility with another code

Comments

@kianorr
Copy link
Collaborator

kianorr commented Jul 26, 2024

Input should allow for different bounds/targets for different coils. I don't think this is possible yet

@kianorr kianorr changed the title Allow for Pytree input for targets and bounds Allow for Pytree input for coil targets and bounds Jul 26, 2024
@kianorr kianorr changed the title Allow for Pytree input for coil targets and bounds Allow for Pytree input for coil objective targets and bounds Jul 26, 2024
@dpanici
Copy link
Collaborator

dpanici commented Aug 13, 2024

  • Preferred: parse the inputs as a pytree like in FixSumCoilCurrents
  • Or document the current method better

@dpanici
Copy link
Collaborator

dpanici commented Aug 13, 2024

#1164 if I have a SumMagneticField with [ToroidalMagneticField, MixedCoilSet]

want to do CoilLength on this, where we target lengths in the mixed coilset differentlt

should target be like [ [], [{"length": 1}, {"length":2}]]

I think we should enforce it having the same pytree structure as the SumMagneticField, but just ignore the entries corresponding to non-coil/coilset leafs

@dpanici dpanici added interface New feature or request to make the code more usable or compatibility with another code enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc coil stuff relating to coils and coil optimization labels Aug 13, 2024
@dpanici
Copy link
Collaborator

dpanici commented Aug 19, 2024

Alternatively, we could allow QuadraticFlux to take in a list of magnetic fields and it just automatically sums them, that way we can say things = (tf_field, coilset) and then have our ususal coil obj target the coilset without needing additional plumbing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coil stuff relating to coils and coil optimization enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc interface New feature or request to make the code more usable or compatibility with another code
Projects
None yet
Development

No branches or pull requests

2 participants