Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take p_newton calculation out of the inner while loop when solving trust region subproblem #1078

Closed
dpanici opened this issue Jun 26, 2024 · 0 comments · Fixed by #1165
Closed

Take p_newton calculation out of the inner while loop when solving trust region subproblem #1078

dpanici opened this issue Jun 26, 2024 · 0 comments · Fixed by #1165
Assignees
@YigitElma
Labels
enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc optimization Adding or improving optimization methods

Comments

@dpanici
Copy link
Collaborator

dpanici commented Jun 26, 2024 •
edited

I still think that we can take p_newton calculation out of the inner while loop. I assume there will be a follow-up PR about QR to make falsefun faster (at least I plan to work on that), so I can try some additional optimizations there. For now, this version is fine and works better than SVD on GPU.

Originally posted by @YigitElma in #1050 (review)
@dpanici dpanici added enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc optimization Adding or improving optimization methods labels Jun 26, 2024
@YigitElma YigitElma mentioned this issue Aug 6, 2024
Merged
@ddudt ddudt closed this as completed in 425fb02 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YigitElma YigitElma

Labels
enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc optimization Adding or improving optimization methods
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Take p_newton out of inner while loop PlasmaControl/DESC
2 participants
@dpanici @YigitElma