[Runtime] Use GIL lock in the runtime instead of custom mutexes. #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 |
|
@maliasadi still under construction 😅 |
a2c5a51
to
19d8056
Compare
|
I know.. I just got too excited 😅 |
|
@erick-xanadu This seemed like a good thing, any chance we can still land this? |
@dime10, needs some more investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: We have a custom mutex that denotes current use of the Python interpreter (a shared resource among threads). This custom mutex may be replaced by the lock found in pybind11.
Description of the Change: Use the scope acquire lock.
Benefits: No custom mutex, better DX with third party libraries. (No need to determine location of the mutex library).
Possible Drawbacks:
Related GitHub Issues: