Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509/pkix.Name now implements String() string, use it #2

Open
philpennock opened this issue Feb 16, 2018 · 0 comments
Open

crypto/x509/pkix.Name now implements String() string, use it #2

philpennock opened this issue Feb 16, 2018 · 0 comments

Comments

@philpennock
Copy link
Member

In the code, wherever we currently reference .CommonName, that was a short-cut because I didn't want to write a full name construction function.

As of Go 1.10, per release notes:

crypto/x509/pkix
Name now implements a String method that formats the X.509 distinguished name in the standard RFC 2253 format.

We should switch to using this and make sure the results still look sane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant