Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Key Group to Entity Set #283

Open
tsalo opened this issue Jan 24, 2024 · 1 comment
Open

Rename Key Group to Entity Set #283

tsalo opened this issue Jan 24, 2024 · 1 comment
Assignees
@tsalo
Labels
breaking-change question Further information is requested

Comments

@tsalo
Copy link
Member

tsalo commented Jan 24, 2024

It seems like we could adopt BIDS's terminology by referring to Key Groups (which are unique entity sets) as Entity Sets instead.
@tsalo tsalo added question Further information is requested breaking-change labels Jan 24, 2024
@mattcieslak
Copy link
Contributor

Entity set is much more precise and intuitive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsalo tsalo

Labels
breaking-change question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattcieslak @tsalo