-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table list not cleared when mirror is deleted #1609
Comments
@iskakaushik this is somewhat intentional, what should the expected behavior be? Is this only about replacing initial load entries? |
@serprex my thought here is that when a flow gets deleted / dropped we should be clearing all the metadata associated with it, for example all the tables in peerdb_stats schema that reference this |
Then we need to come up with another way to recreate mirror while persisting history |
fair point, maybe we can have an optional flag in the delete request -- persist history, default it to false |
Maybe it can be just marked as deleted, to not show history records for new runs with the same name, |
This has been fixed by #2029 where an option (checkbox) is provided when deleting peers where you can choose to keep stats or not. Default - stats are deleted when you drop the mirror |
When we create a mirror, execute and delete it after we finish.
Then we create a new mirror with the same name to repeat processing,
the list of tables in the initial load screen displays new tables and a list of tables from the previous run.
This behavior is intentional or is it not cascade deleted as it should be?
The text was updated successfully, but these errors were encountered: