-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classification model notebook - suggested code updates #12
Comments
Hi Jennifer, Thank you so much for all the fixes. I really appreciate the time you put into this! I made a couple of minor tweaks to your version and updated the repo. Thanks again, Pat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Pat,
Thanks for providing these cheminformatics tutorials and blog posts, I've been learning a lot from them. I was going through the classification notebook (classification_model.ipynb) and had to change the plot code when running it in Google Colab. These code involved the ROC curve, confusion matrix (due to deprecations of old code for sklearn version 1.2 onwards e.g. ROC curve) and dtreeviz plot (seemed to have code updates as shown from dtreeviz repository).
I also happened to come across an issue with one of the SMILES that could not be processed during the "standardize" process (I've added a quick fix in the notebook link as provide below, but unsure if this was appropriate, please check if possible). I've also added some smaller changes to package import code to tie in with the changed plot code too. All code updates were added to another version of this notebook in my forked repo to avoid taking up too much space here.
Thanks again,
Jennifer
The text was updated successfully, but these errors were encountered: