Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF8 encoding #9

Closed
barryvdh opened this issue Sep 6, 2012 · 3 comments
Closed

UTF8 encoding #9

barryvdh opened this issue Sep 6, 2012 · 3 comments
Milestone

Comments

@barryvdh
Copy link

barryvdh commented Sep 6, 2012

I cannot use UTF8 signs, like " ' " or €, but get a ? instead.

@Progi1984
Copy link
Member

Your pull request is a good job.

I will improve it with testing if the text is Unicode : http:https://stackoverflow.com/questions/4407854/how-to-detect-if-have-to-apply-utf8-decode-or-encode-on-a-string .

@ghost
Copy link

ghost commented Dec 15, 2013

Hi, Progi1984,
please, consider the issue #34 and its PR #37. It contains everything necessary for Unicode detection.

The same fix is already merged into PHPOffice by Mark Baker.

@Progi1984
Copy link
Member

Just commited and pushed a fix to your problem : 3c78edd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants