Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespacing #77

Closed
gabrielbull opened this issue Mar 2, 2014 · 7 comments
Closed

Namespacing #77

gabrielbull opened this issue Mar 2, 2014 · 7 comments
Milestone

Comments

@gabrielbull
Copy link
Member

Should the namespacing be done like this:

namespace PHPWord;

class PHPWord
{}

which will result in using the lib like this: new PHPWord\PHPWord();

OR

namespace PHPOffice\PHPWord;

class PHPWord
{}

which will result in using the lib like this: new PHPOffice\PHPWord\PHPWord();

Both of which are PSR-0 and PSR-4 compliant.

@Progi1984
Copy link
Member

I will opt for the second. That would be more general in the PHPOffice project. What do you think about that ?

@Progi1984 Progi1984 mentioned this issue Mar 3, 2014
12 tasks
@gabrielbull
Copy link
Member Author

It's perfect.

@ghost
Copy link

ghost commented Mar 3, 2014

@gabrielbull, how about having "PhpWord" instead of "PHPWord"? It's more readable. Moreover, Zend Framework uses this style.

@gabrielbull
Copy link
Member Author

I totally agree with you. What do you think @Progi1984 ?

So this would be the namespace PhpOffice\PhpWord

@Progi1984
Copy link
Member

I valid ;)

@Progi1984
Copy link
Member

@gabrielbull Can I close this issue ?

@Progi1984 Progi1984 added this to the 0.7.2 milestone Mar 10, 2014
@gabrielbull
Copy link
Member Author

Sure. Issue #58 is the task to integrate namespacing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants