Re-add support for reading nested tables #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 8, 2022 10:08
This commit re-adds supports for nested tables as provided by @mathieuweber in PR PHPOffice#571
|
@Dachande663 Hi, could you tell me where it has been removed ? (May be the PR) |
|
I've found the original PR here. Looks like it was opened but never merged. Also noticed that you're using yoda conditionals unlike the PR, so happy to change so it matches the paragraph check? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit re-adds supports for nested tables as provided by @mathieuweber in PR #571
Description
Support for nested tables was originally provided. This commit merely re-adds it.
Re-Fixes #571
Checklist:
composer run-script check --timeout=0and no errors were reported